WebFX WebBoard
Message Thread:
View All Messages
Back to WebFX
 bug in tabpane.js, Arnaud, July 30, 2003
     Re:bug in tabpane.js, Erik Arvidsson, July 31, 2003
         Re:bug in tabpane.js, Arnaud, August 1, 2003

Subject: Re:bug in tabpane.js From: Erik Arvidsson Date: July 31, 2003
You are correct. However I think that the following test would make more sense:

if (oElement.tabPage && oElement.tabPage.tabPane == this)

because what you really want to check is wether the element is bound to a page and wether that page is part of the pane.

Your test seems to just test that the element is bound to an element?

I realize that there is missing code for actually removing the page from a pane but that is another bug.



In tabpane.js file at line 136 in the function
there's a test to check whether the element to be added is already added:
if ( oElement.tabPage == this ) // already added
return oElement.tabPage;
But the test check if the tabPage of the element refer to the tabPane (this).
The test should be
if (oElement.tabPage.element == oElement)


Enter your reply to this message below. HTML tags are not supported but words that start with http://, ftp:// or mailto: are converted to links.

View All Messages
Back to WebFX